[PATCH] D37903: Fix assume-filename handling in clang-format.el

Micah Werbitt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 19 05:17:55 PDT 2017


werbitt added a comment.

Hi,

Thank you very much for your feedback.

I submitted a bug here:
https://bugs.llvm.org/show_bug.cgi?id=34667

I made the changes you suggested, but I left the assume-filename optional argument for now.

My current use-case is that when I'm editing a source block in an orgmode file, the code is in new buffer that doesn't have a buffer-file-name. If I'm able to pass in the base orgmode buffer-file-name, I can apply the .clang-format file from the correct directory. Without it, I'll need to locate the .clang-format file and use it to populate the style argument, which would be a lot of extra code on my end.

If you still think it's not worth it to have the assume-file argument let me know and I'll remove it.

Thanks,
Micah


https://reviews.llvm.org/D37903





More information about the cfe-commits mailing list