[PATCH] D37865: [Sema] Fix a pair of crashes when generating exception specifiers with an error'ed field for a template class' default ctor.

[Erich Keane via Phabricator via cfe-commits]

erichkeane created this revision.

The two examples in the test would both cause a compiler assert when attempting to calculate 
the exception specifier for the default constructor for the template classes.  The problem was
that dependents of this function expect that Field->getInClassInitializer (including canThrow) is
not nullptr.  However, if the template's initializer has an error, exactly that situation happens.

This patch simply sets the field to be invalid.


https://reviews.llvm.org/D37865

Files:
  lib/Sema/SemaDeclCXX.cpp
  test/SemaCXX/init-expr-crash.cpp


Index: test/SemaCXX/init-expr-crash.cpp
===================================================================
--- /dev/null
+++ test/SemaCXX/init-expr-crash.cpp
@@ -0,0 +1,31 @@
+// RUN: %clang_cc1 %s -fsyntax-only -verify -std=c++11
+
+// Test reproduces a pair of crashes that were caused by code attempting
+// to materialize a default constructor's exception specifier.
+
+template <class T> struct A {
+  static T tab[];
+
+  const int M = UNDEFINED; // expected-error {{use of undeclared identifier}}
+
+  int main()
+  {
+    A<char> a;
+
+    return 0;
+  }
+};
+
+template <class T> struct B {
+  static T tab[];
+
+  // expected-error at +1 {{invalid application of 'sizeof' to an incomplete type}}
+  const int N = sizeof(B<char>::tab) / sizeof(char);
+
+  int main()
+  {
+    B<char> b;
+
+    return 0;
+  }
+};
Index: lib/Sema/SemaDeclCXX.cpp
===================================================================
--- lib/Sema/SemaDeclCXX.cpp
+++ lib/Sema/SemaDeclCXX.cpp
@@ -12436,7 +12436,8 @@
       assert(Pattern && "We must have set the Pattern!");
     }
 
-    if (InstantiateInClassInitializer(Loc, Field, Pattern,
+    if (!Pattern->hasInClassInitializer() ||
+        InstantiateInClassInitializer(Loc, Field, Pattern,
                                       getTemplateInstantiationArgs(Field))) {
       // Don't diagnose this again.
       Field->setInvalidDecl();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D37865.115278.patch
Type: text/x-patch
Size: 1385 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170914/a9ed83a0/attachment-0001.bin>