[PATCH] D36720: [libc++] Prevent stale site configuration headers

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added inline comments.


================
Comment at: CMakeLists.txt:633
+  if (EXISTS "${site_config_path}")
+    file(REMOVE "${site_config_path}")
+  endif()
----------------
EricWF wrote:
> Maybe print a warning or a message here? While it seems useful to re-configure and remove the stale header without requiring the user delete the build directory, it does seem like an odd thing to do, at least silently.
> 
> Since this shouldn't be happening very often, I don't think it would be too noisy to explicitly warn the user what is going on.
> 
Sounds good.


https://reviews.llvm.org/D36720