[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Daniel Jasper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 14 00:58:37 PDT 2017


djasper added a comment.

I still don't understand yet. breakProtrudingToken has basically two options:

1. Don't wrap/reflow: In this case the penalty is determined by the number of excess characters.
2. Wrap/reflow: I this case the penalty is determined by PenaltySplitComments plus the remaining excess characters.

My question is, why do you need to put anything into the state and do this outside of breakProtrudingToken. It seems to me that breakProtrudingToken can do this locally without putting anything into the State.


https://reviews.llvm.org/D33589





More information about the cfe-commits mailing list