[PATCH] D36719: [libc++] Add site config option for ABI macros

[Eric Fiselier via Phabricator via cfe-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D36719#841499, @smeenai wrote:

> There should probably be some documentation for this, but I couldn't think of the right place; the Using libc++ documentation only mentions the actual configuration macros, not their corresponding cmake defines. Any suggestions?


`docs/BuildingLibcxx.rst` under "libc++ ABI Feature Options".

LGTM after adding documentation, and addressing the inline comment.



================
Comment at: CMakeLists.txt:610
 
+if (LIBCXX_ABI_DEFINES)
+  set(abi_defines)
----------------
Should `LIBCXX_ABI_DEFINES` be a cache variable that has documentation? ex:

```
set(LIBCXX_ABI_DEFINES "" CACHE STRING "A semicolon separated list of ABI macros to define in the site config header")
```


https://reviews.llvm.org/D36719