[PATCH] D37133: [libc++] Handle object files named *.obj in merge_archives.py

Eric Fiselier via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 12 13:17:39 PDT 2017


EricWF added a comment.

In https://reviews.llvm.org/D37133#860549, @compnerd wrote:

> I think we should avoid this logic entirely and use CMake to do this.


It's not that easy to do in CMake, and a CMake solution would be limited to only
merging in-tree builds together. This script allows merging any two static libraries,
including merging an installed libc++abi into an in-tree libc++ build.

Obviously I'm biased because I wrote the script initially, but I still prefer a python
solution.


https://reviews.llvm.org/D37133





More information about the cfe-commits mailing list