[PATCH] D34158: For Linux/gnu compatibility, preinclude <stdc-predef.h> if the file is available

[Blower, Melanie via cfe-commits]

> -----Original Message-----
> From: Joerg Sonnenberger via Phabricator [mailto:reviews at reviews.llvm.org]
> Sent: Tuesday, September 12, 2017 3:24 PM
> To: Blower, Melanie <melanie.blower at intel.com>; olivier.jg at gmail.com;
> kalinichev.so.0 at gmail.com; kfunk at kde.org; mail at milianw.de; Keane, Erich
> <erich.keane at intel.com>; mgorny at gentoo.org; fedor.v.sergeev at gmail.com;
> richard at metafoo.co.uk; renato.golin at linaro.org
> Cc: hfinkel at anl.gov; jyknight at google.com; ibiryukov at google.com; cfe-
> commits at lists.llvm.org; klimek at google.com; simon.dardis at imgtec.com;
> anastasia.stulova at arm.com; arichardson.kde at gmail.com
> Subject: [PATCH] D34158: For Linux/gnu compatibility, preinclude <stdc-
> predef.h> if the file is available
> 
> joerg added a comment.
> 
> This version is fine with me. The only contentious part is whether it should be
> opt-in or opt-out for platforms, so getting this version in and revisiting the issue
> again later is OK from my perspective.
> 
> 
> https://reviews.llvm.org/D34158
> 
> 
[Blower, Melanie] That's great news, thank you.  Please note there are changes to some clang extra tests needed with this change.  The review is here, https://reviews.llvm.org/D34624.  You could patch the extra tests before accepting the patch for D34158 (the test changes aren't dependent on D34158).  How is platform opt-in accomplished, is it part of the configure step?