[PATCH] D37376: [libcxx] Fix libc++experimental build on Windows

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/CMakeLists.txt:189
 
+macro(add_msvcrt_defs_if_needed target)
+  if(WIN32 AND NOT MINGW)
----------------
Please use `function` rather than `macro`.  There is no need to pollute the namespace here.


https://reviews.llvm.org/D37376