[PATCH] D37677: [libc++] implement future synchronization using atomic_flag

Ben Craig via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 11 06:20:29 PDT 2017


bcraig added a comment.

Is there a benchmark where this demonstrates some performance improvement?  I fear that the switch to condition_variable_any will swamp any performance gains from the switch to a spin lock.

Also, the spin lock is being held during allocating operations (the exception throws and at_thread_exit code).  That's a little long to be holding a spin lock.


https://reviews.llvm.org/D37677





More information about the cfe-commits mailing list