[PATCH] D36642: [Lexer] Report more precise skipped regions (PR34166)

[Vedant Kumar via Phabricator via cfe-commits]

vsk added inline comments.


================
Comment at: test/Index/skipped-ranges.c:23
 // RUN: env CINDEXTEST_SHOW_SKIPPED_RANGES=1 c-index-test -test-annotate-tokens=%s:1:1:16:1 %s | FileCheck %s
-// CHECK: Skipping: [5:2 - 6:7]
-// CHECK: Skipping: [8:2 - 12:7]
-// CHECK: Skipping: [14:2 - 20:7]
+// CHECK: Skipping: [5:1 - 7:1]
+// CHECK: Skipping: [8:1 - 13:1]
----------------
arphaman wrote:
> Some editor clients might want to grey out the skipped PP ranges. The new end location is not ideal as we wouldn't want to grey out the trailing comments after the `#endif`.
It seems like the end location we want should be different for the coverage client and the indexer. I'll modify the callback so we pass along both end locations.


https://reviews.llvm.org/D36642