[PATCH] D37413: [X86][MS-InlineAsm] Extended support for variables / identifiers on memory / immediate expressions

[Simon Pilgrim via Phabricator via cfe-commits]

RKSimon added a reviewer: RKSimon.
RKSimon added a comment.

Tests?



================
Comment at: lib/Sema/SemaStmtAsm.cpp:71
+    if (!Piece.isOperand())
+      continue;
 
----------------
This all looks like a clang-format NFC change - just commit it?


================
Comment at: lib/Sema/SemaStmtAsm.cpp:617
+    return;
+  } else if (Res->isRValue()) {
+    bool Enum = isa<clang::EnumType>(T) && Res->EvaluateAsRValue(Eval, Context);
----------------
(style) Split these instead of an if-elseif chain


Repository:
  rL LLVM

https://reviews.llvm.org/D37413