[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

Zachary Turner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 7 18:05:13 PDT 2017


zturner added a comment.

@inglorion : Since we're already in this code anyway, should we at least do due diligence and check the basics, even if only manually?  As in, at least we should check in MSVC if any of those other types of examples that I came up with present a problem.  Otherwise we're going to be back here fixing this again in a few weeks.  And it doesn't seem like it would be that hard to whip up some sample code with 10 or 12 cases and just do a sanity check that they all work.  If they don't, we can then decide whether it should be fixed in this patch, or a bug can be filed to track it.


https://reviews.llvm.org/D37529





More information about the cfe-commits mailing list