[PATCH] D37529: [codeview] omit debug locations for nested exprs unless column info enabled

[Zachary Turner via Phabricator via cfe-commits]

zturner added inline comments.


================
Comment at: clang/test/CodeGenCXX/debug-info-nested-exprs.cpp:44
+  int a = bar(x, y) +
+          baz(x, z) +
+          qux(y, z);
----------------
inglorion wrote:
> zturner wrote:
> > Can you make a function called `int foo()` and make this `int a = bar(foo(), y) + ...`
> Yes. Why? To test an additional level of nesting?
Yes.  for that matter, even better would be if this call to `foo()` spans multiple lines.  Right here you've got a single statement which spans multiple lines, but no individual sub-expression spans multiple lines.  And FWICT there is no nesting at all, since + is just a builtin operator.


https://reviews.llvm.org/D37529