r312595 - [Darwin] Enable -fstack-protector (back) by default with -ffreestanding

Bruno Cardoso Lopes via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 5 17:45:59 PDT 2017


On Tue, Sep 5, 2017 at 4:58 PM, Joerg Sonnenberger via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
> On Tue, Sep 05, 2017 at 11:50:58PM -0000, Bruno Cardoso Lopes via cfe-commits wrote:
>> Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=312595&r1=312594&r2=312595&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Driver/ToolChains/Clang.cpp (original)
>> +++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp Tue Sep  5 16:50:58 2017
>> @@ -2302,11 +2302,6 @@ static void RenderSSPOptions(const ToolC
>>      else if (A->getOption().matches(options::OPT_fstack_protector_all))
>>        StackProtectorLevel = LangOptions::SSPReq;
>>    } else {
>> -    // Only use a default stack protector on Darwin in case -ffreestanding is
>> -    // not specified.
>> -    if (EffectiveTriple.isOSDarwin() && !IsHosted)
>> -      StackProtectorLevel = 0;
>> -    else
>>        StackProtectorLevel = DefaultStackProtectorLevel;
>>    }
>
> Indentation?

Thanks for the catch, done in r312599

>
> Joerg
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits



-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc


More information about the cfe-commits mailing list