[PATCH] D37448: Fix cast assertion on MS inline assembly with vector spills (PR34021)

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 5 14:03:13 PDT 2017


erichkeane added a comment.

In https://reviews.llvm.org/D37448#861443, @efriedma wrote:

> > According to our definition, v4si is NOT a "Vector" type, since a vector type requires it be a FP value.
>
> Umm, what?  An integer vector is still a vector.  The backend will return it in xmm0 on x86 (both 32 and 64-bit).


Ugg.. you're right.  I missed that addReturnRegisterOutputs was creating a return type as an integer, so when it was being checked in this if/else tree (edited above) you're not actually looking at the return type anymore....


Repository:
  rL LLVM

https://reviews.llvm.org/D37448





More information about the cfe-commits mailing list