[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

[Raoul Wols via Phabricator via cfe-commits]

rwols marked 4 inline comments as done.
rwols added inline comments.


================
Comment at: clangd/ClangdUnit.cpp:419
+        assert(item.detail.empty() && "Unexpected extraneous CK_ResultType");
+        Item.detail = Chunk.Text;
+        break;
----------------
ilya-biryukov wrote:
> Won't that assertion fail with function return types? Let's add a test for that.
> 
> ```
> int (*foo(int a))(float);
> ```
I'll make sure to add a test case for this!


https://reviews.llvm.org/D37101