[PATCH] D37390: [diagtool] Add list-warning-flags

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 1 14:29:24 PDT 2017


aprantl added a comment.

Can this be tested?



================
Comment at: tools/diagtool/ListWarningFlags.cpp:36
+  for (ArrayRef<DiagnosticRecord>::iterator di = AllDiagnostics.begin(),
+                                            de = AllDiagnostics.end();
+       di != de; ++di) {
----------------
range-based for / auto?


================
Comment at: tools/diagtool/ListWarningFlags.cpp:38
+       di != de; ++di) {
+    unsigned diagID = di->DiagID;
+    llvm::StringRef flag = DiagnosticIDs::getWarningOptionForDiag(diagID);
----------------
The LLVM style wants variables to begin with an uppercase letter.


Repository:
  rL LLVM

https://reviews.llvm.org/D37390





More information about the cfe-commits mailing list