[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

[Richard Smith via cfe-commits]

On 30 August 2017 at 11:52, Boris Kolpackov via cfe-commits <
cfe-commits at lists.llvm.org> wrote:

> Victor Leschuk <vleschuk at accesssoftek.com> writes:
>
> > Hello Boris, looks like this revision broke tests on our win10 builder:
> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_
> 64-scei-ps4-windows10pro-fast/builds/11760
> >
> > Clang :: CXX/modules-ts/basic/basic.link/module-declaration.cpp
> >
> > I had to revert this revision. Could you please take a look?
>
> Sorry about that.
>
> I took a look and it seems the problem is with the test's path regex:
>
> '{{.*}}/x.pcm'
>
> Which, on Windows, is being matched against a path like this:
>
> ...\module-declaration.cpp.tmp\x.pcm
>
> It looks like the "canonical" fix for this is to use [/\\].
>
> What is the protocol in this situation? Should I fix the test and then
> re-apply my patch?


Yes, please.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20170830/55f94d6c/attachment.html>