[clang-tools-extra] r312141 - [clang-tidy] fix buildbot

Jonas Toth via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 30 10:21:41 PDT 2017


Author: jonastoth
Date: Wed Aug 30 10:21:41 2017
New Revision: 312141

URL: http://llvm.org/viewvc/llvm-project?rev=312141&view=rev
Log:
[clang-tidy] fix buildbot

Use `signed char` instead of `char`.

Modified:
    clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise.cpp

Modified: clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise.cpp?rev=312141&r1=312140&r2=312141&view=diff
==============================================================================
--- clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise.cpp (original)
+++ clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise.cpp Wed Aug 30 10:21:41 2017
@@ -17,10 +17,10 @@ StreamClass &operator>>(StreamClass &os,
 }
 struct AnotherStream {
   AnotherStream &operator<<(unsigned char c) { return *this; }
-  AnotherStream &operator<<(char c) { return *this; }
+  AnotherStream &operator<<(signed char c) { return *this; }
 
   AnotherStream &operator>>(unsigned char c) { return *this; }
-  AnotherStream &operator>>(char c) { return *this; }
+  AnotherStream &operator>>(signed char c) { return *this; }
 };
 
 void binary_bitwise() {
@@ -47,8 +47,8 @@ void binary_bitwise() {
 
   unsigned char UByte1 = 0u;
   unsigned char UByte2 = 16u;
-  char SByte1 = 0;
-  char SByte2 = 16;
+  signed char SByte1 = 0;
+  signed char SByte2 = 16;
 
   UByte1 = UByte1 & UByte2; // Ok
   UByte1 = SByte1 & UByte2;
@@ -88,12 +88,12 @@ void binary_bitwise() {
 }
 
 void f1(unsigned char c) {}
-void f2(char c) {}
+void f2(signed char c) {}
 void f3(int c) {}
 
 void unary_bitwise() {
   unsigned char UByte1 = 0u;
-  char SByte1 = 0;
+  signed char SByte1 = 0;
 
   UByte1 = ~UByte1; // Ok
   SByte1 = ~UByte1;
@@ -164,7 +164,7 @@ void streams_should_work() {
 
   AnotherStream as;
   unsigned char uc = 1u;
-  char sc = 1;
+  signed char sc = 1;
   as << uc; // Ok
   as << sc; // Ok
   as >> uc; // Ok




More information about the cfe-commits mailing list