[PATCH] D37005: [clang-diff] Initial implementation of patching

Johannes Altmanninger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 06:23:11 PDT 2017


johannes added inline comments.


================
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:73
 public:
+  /// Empty (invalid) SyntaxTree.
+  SyntaxTree();
----------------
arphaman wrote:
> Why do you need to create an empty tree? What about using llvm::Optional instead?
ok, i use optional now instead in the unittest


https://reviews.llvm.org/D37005





More information about the cfe-commits mailing list