[PATCH] D37005: [clang-diff] Initial implementation of patching

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 29 05:32:40 PDT 2017


arphaman added inline comments.


================
Comment at: include/clang/Tooling/ASTDiff/ASTPatch.h:1
+//===- ASTDiff.h - Structural patching based on ASTDiff -------*- C++ -*- -===//
+//
----------------
Please update the file name in the comment


================
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:656
+  if (N.ASTNode.get<TemplateArgument>())
+    Range = TemplateArgumentLocations.at(&N - &Nodes[0]);
+  else {
----------------
You might as well return early here and avoid else entirely 


https://reviews.llvm.org/D37005





More information about the cfe-commits mailing list