[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 13:56:56 PDT 2017


rsmith added a comment.

This patch appears to be missing some necessary changes in the following places:

- lib/Serialization -- round-trip the new information through PCH / modules
- lib/AST/StmtPrinter.cpp -- pretty-printing lambdas with explicit template parameters
- lib/Sema/TreeTransform.h -- template instantiation of lambdas with explicit template arguments
- lib/AST/RecursiveASTVisitor.h -- recursive AST visitation should visit explicit template parameters

We'll also need to agree within the cxx-abi-dev list how to mangle lambda closure types for this form and lib/AST/ItaniumMangle.cpp's `mangleLambda` will need to be updated to match. (The MS mangling is not based on the type of the lambda call operator, so we probably don't need changes there.)


https://reviews.llvm.org/D36527





More information about the cfe-commits mailing list