r311899 - Fix inaccurate comment about -fdelayed-template-parsing and MSVC

Reid Kleckner via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 10:59:24 PDT 2017


Author: rnk
Date: Mon Aug 28 10:59:24 2017
New Revision: 311899

URL: http://llvm.org/viewvc/llvm-project?rev=311899&view=rev
Log:
Fix inaccurate comment about -fdelayed-template-parsing and MSVC

Modified:
    cfe/trunk/lib/Driver/ToolChains/Clang.cpp

Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=311899&r1=311898&r2=311899&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/ToolChains/Clang.cpp (original)
+++ cfe/trunk/lib/Driver/ToolChains/Clang.cpp Mon Aug 28 10:59:24 2017
@@ -3846,8 +3846,10 @@ void Clang::ConstructJob(Compilation &C,
                     !IsWindowsMSVC || IsMSVC2015Compatible))
     CmdArgs.push_back("-fno-threadsafe-statics");
 
-  // -fno-delayed-template-parsing is default, except for Windows where MSVC STL
-  // needs it.
+  // -fno-delayed-template-parsing is default, except when targetting MSVC.
+  // Many old Windows SDK versions require this to parse.
+  // FIXME: MSVC introduced /Zc:twoPhase- to disable this behavior in their
+  // compiler. We should be able to disable this by default at some point.
   if (Args.hasFlag(options::OPT_fdelayed_template_parsing,
                    options::OPT_fno_delayed_template_parsing, IsWindowsMSVC))
     CmdArgs.push_back("-fdelayed-template-parsing");




More information about the cfe-commits mailing list