[PATCH] D37104: [libc++] PR34298: Change std::function constructor and move assignment operator SFINAE checks to allow std::function with an incomplete return type

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 10:39:59 PDT 2017


mclow.lists added inline comments.


================
Comment at: test/libcxx/utilities/function.objects/func.require/incomplete_return_type.pass.cpp:1
+//===----------------------------------------------------------------------===//
+//
----------------
mclow.lists wrote:
> Is this file in the right place?
> If it's supposed to test functionality that is required by the standard, it should go in `test/std` somewhere. 
> If it's supposed to test a libc++ extension, then it should go into `test/libcxx`.
Never mind - I missed the "Non-standard extension" bit.



Repository:
  rL LLVM

https://reviews.llvm.org/D37104





More information about the cfe-commits mailing list