[PATCH] D37203: [Bash-autocompletion] Follow up patch for D36782

Rui Ueyama via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 09:26:13 PDT 2017


ruiu added a comment.

Technically, this patch fixes your issue, but I don't think this is a good way of fixing it because `parse()` function now has an internal state which is not obvious to the user of the function. Can you review https://reviews.llvm.org/D37217? This is an alternative fix that doesn't use a static local variables.


https://reviews.llvm.org/D37203





More information about the cfe-commits mailing list