[PATCH] D37181: {StaticAnalyzer} LoopUnrolling: Keep track the maximum number of steps for each loop

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 28 01:54:48 PDT 2017


NoQ added a comment.

LGTM, thanks! Minor nit included. I hope our matchers actually cover all the cases (not a big deal if they don't though).



================
Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:26
 
+#define MAXIMUM_STEP_UNROLLED 128
+
----------------
I'd prefer a (`static`) `const int`, dealing preprocessor doesn't seem to be necessary here.


https://reviews.llvm.org/D37181





More information about the cfe-commits mailing list