[PATCH] D37180: [modules] Add test for using declaration in classes.

Vassil Vassilev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 27 06:56:41 PDT 2017

v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.

LGTM! I'd reword the commit message, saying that we intended to add a fast path in `DeclContext::removeDecl` which checks if the decl is hidden to avoid addition in the lookup tables. That caused problems with modules, because the modules system extends the definition of visibility and this is a test making sure we do not reintroduce such an issue.



More information about the cfe-commits mailing list