[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 26 02:37:29 PDT 2017

JonasToth added inline comments.

Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:294
+    diag(BadClass->getLocStart(),
+         "class with an 'gsl::owner<>' as member but without declared "
aaron.ballman wrote:
> Instead of diagnosing this on the class, why not diagnose the individual offending members (and then you don't need a note, either)? (Note, that may change the suggested diagnostic wording below).
yes, this is probably better.
i plan to add deeper analysis, that `gsl::owner<>` will always be released or moved.
That would check, if destructors do this correctly, so offending the member is the better way.


More information about the cfe-commits mailing list