[PATCH] D37001: [clang-diff] Use data collectors for node comparison

Johannes Altmanninger via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 25 07:56:06 PDT 2017

johannes added a comment.

In https://reviews.llvm.org/D37001#852442, @arphaman wrote:

> Can you remove `getNodeValue` now or do you still need it?

It is only used in the client, I think it makes sense to move it there, or to remove it altogether.
I think I'd keep it in the client for now, to disambiguate things with different names in the tests.


More information about the cfe-commits mailing list