[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 24 13:16:52 PDT 2017


rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

Please add a test that the attribute is emitted into IR. Other than that, this looks good to me.



================
Comment at: include/clang/Driver/Options.td:645
+               profile is accurate, callsites without profile samples are marked
+               as cold. Otherwise, treat callsites without profile samples as if
+               we have no profile}]>;
----------------
Consistently use passive voice here: "treat callsites without profile samples" -> "callsites without profile samples are treated"


================
Comment at: include/clang/Driver/Options.td:646
+               as cold. Otherwise, treat callsites without profile samples as if
+               we have no profile}]>;
+def fno_profile_sample_accurate : Flag<["-"], "fno-profile-sample-accurate">,
----------------
Add a trailing period.


https://reviews.llvm.org/D37091





More information about the cfe-commits mailing list