[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

Anatol Pomozov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 24 11:50:08 PDT 2017


anatol.pomozov added a comment.

> Additionally, there is likely value to split the test run-line into 2, one that specifies 64 bit Windows and one that is 64 bit Linux.  The value being that they validate two different code paths (whereas 32 is the same code path).

I added a RUN for triplet '-triple x86_64-pc-win32' and tests are failing for me. I rebuilt clang without my patches and still see the same failure. It looks like the original function-attributes currently does not work with win32 triplet.

  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /mnt/cold/sources/llvm/tools/clang/test/CodeGen/function-attributes.c:76:21: warning: unknown attribute 'force_align_arg_pointer' ignored
  void __attribute__((force_align_arg_pointer)) f16(void) {
                      ^
  1 warning generated.
  /mnt/cold/sources/llvm/tools/clang/test/CodeGen/function-attributes.c:4:11: error: expected string not found in input
  // CHECK: define signext i8 @f0(i32 %x) [[NUW:#[0-9]+]]
            ^
  <stdin>:1:1: note: scanning from here
  ; ModuleID = '/mnt/cold/sources/llvm/tools/clang/test/CodeGen/function-attributes.c'
  ^
  <stdin>:7:1: note: possible intended match here
  define i8 @f0(i32 %x) #0 {
  ^
  /mnt/cold/sources/llvm/tools/clang/test/CodeGen/function-attributes.c:67:11: error: expected string not found in input
  // CHECK: [[NUW]]
            ^
  <stdin>:158:17: note: scanning from here
  define void @f15() #0 {
                  ^
  <stdin>:158:17: note: uses undefined variable "NUW"
  define void @f15() #0 {
                  ^
  /mnt/cold/sources/llvm/tools/clang/test/CodeGen/function-attributes.c:104:11: error: expected string not found in input
  // CHECK: call i32 @_setjmp(i32* null)
            ^
  <stdin>:191:1: note: scanning from here
  entry:
  ^
  <stdin>:193:7: note: possible intended match here
   %1 = call i32 @_setjmp(i8* null, i8* %0) #7
        ^
  
  --


https://reviews.llvm.org/D36272





More information about the cfe-commits mailing list