[PATCH] D36075: [refactor] Initial support for refactoring action rules

Alexander Shaposhnikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 24 11:17:30 PDT 2017


alexshap added a comment.

@arphaman

  The selection requirement is supposed to be orthogonal to AST matchers, not a replacement. It should be used when working with source selection in editors. 
  I did mess around with moving over clang-reorder-fields using this kind of model and didn't see any issues when using AST matchers. Essentially I used the  requiredOption requirements and mapped them to run my 
  matching code instead of using the selection requirement. Thus this requirement was satisfied only when the AST matchers were successful. 
  It might be possible to simplify that pattern even further to make it simpler.

that's great, i'm interested in this too and would be happy to see clang-reorder-fields moving to clang-refactor (pls, let me know if i can help make this happen)


Repository:
  rL LLVM

https://reviews.llvm.org/D36075





More information about the cfe-commits mailing list