[PATCH] D37004: [clang-diff] Fix the html output for CXXOperatorCallExpr

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 24 06:35:19 PDT 2017

arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

LGTM with one request below:

Comment at: tools/clang-diff/ClangDiff.cpp:319
+           "A Binary operator is supposed to have two arguments.");
+    for (int I : {1, 0, 2})
+      Offset = printHtmlForNode(OS, Diff, Tree, IsLeft, Children[I], Offset);
Please add a short comment that describes why this out-of-order traversal is required


More information about the cfe-commits mailing list