[PATCH] D34984: Store token literal data in PCH. Avoids disk read on PreProc expansion.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 23 11:46:53 PDT 2017

rsmith added a comment.

Seems reasonable to store this with the token. Do you have performance data?

Comment at: include/clang/Serialization/ASTReader.h:616
+  /// \brief Token literal data loaded and owned by us.
+  std::vector<std::string *> TokenLiteralDataLoaded;
Remove this use pointers directly into blob data from the token record (or BumpPtrAllocate the strings using the preprocessor's allocator if there's some reason you can't use blob data).

Comment at: lib/Serialization/ASTWriter.cpp:4360
   // FIXME: When reading literal tokens, reconstruct the literal pointer
   // if it is needed.
Remove this FIXME


More information about the cfe-commits mailing list