[PATCH] D36555: Move x86-specific sources to x86-specific source lists.
Michał Górny via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 22 21:29:17 PDT 2017
mgorny added inline comments.
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:223
> mgorny wrote:
> > This and the following files have only:
> > ```
> > #if !_ARCH_PPC
> > ```
> > so I suppose it's currently included on more targets than x86. If it's really not useful there, I think it'd be better to update the `#if`s first (and preferably get the author to review).
> As discussed in D36764, these all assume 80-bit floats, and therefore are only useful on x86 (and ancient 68ks)--and, in fact, the tests for these functions are disabled for everything but x86. I have left these #ifs in for now, but will remove them after this patch gets submitted (and add comments about them needing 80-bit floats). Otherwise, powerpc builds will be broken.
Please do not remove the guards. We're using them in other arch-specific files as well. Instead, update them to state the correct targets.
More information about the cfe-commits