[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 22 17:10:51 PDT 2017

aprantl added a comment.

Performance-wise the change is fine because it does the same amount of work, but I would prefer someone to audit the code to make sure that we aren't uniquing a node while we still want to make changes to it. Unfortunately testcases for these issues will involve impossibly nested C++ so it may take a while to find a counterexample in the wild. That's why I'd rather read the code instead :-)


More information about the cfe-commits mailing list