[PATCH] D37024: [libcxx] [test] Cleanup nullopt_t tests

Stephan T. Lavavej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 22 14:10:57 PDT 2017

STL_MSFT added a comment.

Otherwise, looks cromulent to me.

Comment at: test/std/utilities/optional/optional.nullopt/nullopt_t.pass.cpp:38
-    static_assert(test(nullopt) == 3, "");
+    static_assert(std::is_same_v<const nullopt_t, decltype(std::nullopt)>);
+    static_assert(test());
You're saying `std::nullopt` but you already dragged it in.


More information about the cfe-commits mailing list