[PATCH] D36712: Emit section information for extern variables

Simon Dardis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 22 05:35:48 PDT 2017

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

I agree with @kparzysz here. If there is a mis-match between the declaration and definition, there are cases where undesirable behaviour (as such) will not occur depending on how the mismatch occurs.

One suggestion inline for the wording inline, the important part is making explicit

LGTM, anyone else have more comments?

Comment at: docs/LangRef.rst:582-584
+to be placed in and may have an optional explicit alignment specified. A 
+mismatch between section information in the variable declaration and its
+definition is undefined behavior. 
"If there is a mismatch between the explicit or inferred section information for the variable declaration and its definition the resulting behaviour is undefined."


More information about the cfe-commits mailing list