[PATCH] D35271: Fix printing policy for AST context loaded from file

Johann Klähn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 21 05:08:57 PDT 2017

jklaehn added a comment.

In https://reviews.llvm.org/D35271#809159, @vsk wrote:

> I wonder if it's possible to do away with the calls to 'updated()'... it seems strange that we initialize the same preprocessor repeatedly. Is there any way to finalize an ASTInfoCollector after ReadAST happens (or ASTReaderListeners in general)?

I can look into this but would prefer to do so in a different patch, as this would require refactoring beyond this simple bug fix. Would it be okay to land this patch as-is?


More information about the cfe-commits mailing list