[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas
Hamza Sood via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Aug 20 07:41:12 PDT 2017
hamzasood updated this revision to Diff 111887.
hamzasood added a comment.
- Corrected a typo.
- Made HasExplicitTemplateParams const.
- Reverted the change in where template depth is incremented and recorded.
- Fixed the broken test.
- Keep the template scope active instead of exiting it and manually introducing the template parameters into scope. I think this works fine now; you can see the fix in line 847 of SemaLambda.cpp. Basically having a template scope active resulted in the lambda being incorrectly marked as dependent, which broke a lot of stuff.
One question I have is how to expose explicit template params in the AST (if at all)? I was thinking of adding an int representing the number of template params that were explicitly specified. But do I add that to LambdaExpr or CXXRecordDecl::LambdaDefinitionData (or both)?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 16755 bytes
Desc: not available
More information about the cfe-commits