[PATCH] D36820: [Bash-autocompletion] Add support for -std=

Yuka Takahashi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 18 22:46:44 PDT 2017

yamaguchi added inline comments.

Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:319-320
         OS << ", Values);\n";
         OS << "(void)ValuesWereAdded;\nassert(ValuesWereAdded &&";
         OS << " \"Couldn't add values to OptTable!\");\n";
ruiu wrote:
> Can you split the string after each "\n"? It seems the current way of splitting is somewhat arbitrary.
Those code are on review in D36782 and I've fixed it, so I think it's fine now :)


More information about the cfe-commits mailing list