[PATCH] D36860: [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure

Stephan T. Lavavej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 18 18:59:44 PDT 2017

STL_MSFT added a comment.

In https://reviews.llvm.org/D36860#846232, @thakis wrote:

> Many driver tests check in a basic representative directory structure (e.g. test/Driver/Inputs/basic_freebsd_tree/ and its many siblings).
> But if you're happy with others breaking this code, I suppose having no tests is ok; I imagine most people won't use this code :-)

I can't check in copies of `cl.exe` and `link.exe` (the former's version is inspected, so it can't just be a dummy file). I'm happy without upstream tests for this logic. In the long run, I hope that we can eliminate this internal directory structure and make it identical to the released directory structure.


More information about the cfe-commits mailing list