[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

Thanks, will you need someone to commit this for you?



================
Comment at: include/clang/Basic/DiagnosticGroups.td:794
+// earlier C++ versions.
+def CXX20 : DiagGroup<"c++20-extensions">;
+
----------------
We've historically avoided using precise year numbers until a standard is finalized. I would call this `CXX2a` for now, and only provide the `c++2a-extensions` spelling, just in case the next standard ships a year late (or early).


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4095-4096
+def warn_cxx17_compat_pointer_to_const_ref_member_on_rvalue : Warning<
+  "pointer-to-member function for const& member function on rvalues is "
+  "incompatible with C++ standards before C++2a">,
+  InGroup<CXXPre2aCompat>, DefaultIgnore;
----------------
Please also update this to match the prior diagnostic's text.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4097
+  "incompatible with C++ standards before C++2a">,
+  InGroup<CXXPre2aCompat>, DefaultIgnore;
 def ext_ms_deref_template_argument: ExtWarn<
----------------
This should now be in a `CXXPre2aCompatPedantic` group, because the corresponding extension is a pedantic warning.


https://reviews.llvm.org/D36855