[PATCH] D36731: [ARM][AArch64] Cortex-A75 and Cortex-A55 tests

Sam Parker via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 18 05:12:41 PDT 2017


samparker added a comment.

Thanks guys, I will sort my logic out.

Renato, the new Decode function is really just there to allow me to double check the target features. This is already possible with AArch64 and it just felt right to also be able to test ARM in the same way. I've renamed the title so others aren't mislead.

cheers,
sam



================
Comment at: test/Driver/arm-cortex-cpus.c:261
 // RUN: %clang -target arm -mlittle-endian -march=armv8.2-a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V82A %s
-// CHECK-V82A: "-cc1"{{.*}} "-triple" "armv8.2{{.*}}" "-target-cpu" "generic"
+// CHECK-V82A: "-cc1"{{.*}} "-triple" "armv8.2{{.*}}" "-target-cpu" "cortex-a55"
 
----------------
SjoerdMeijer wrote:
> Just checking: why has the default cpu changed from generic to cortex-a55, and secondly, is that what we want?
I was thinking about this on the way to work, and no I don't think it is what we want! I will change this.


https://reviews.llvm.org/D36731





More information about the cfe-commits mailing list