[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 17 18:03:46 PDT 2017

yaxunl added a comment.

In https://reviews.llvm.org/D35082#844620, @rjmccall wrote:

> The meaning we've agreed on for LangAS::Default is to be the address space of local declarations, which corresponds quite well to __private in OpenCL.  I think your concern about diagnostics is better addressed by changing the pretty-printer than by changing Sema to give all local declarations qualified type.

How about adding a ImplicitAddrSpace bit to Qualifier to indicate address space is implicit, then does not print the address space qualifier in AST printer if the bit is set.


More information about the cfe-commits mailing list