[PATCH] D36839: [SanitizerCoverage] Add stack depth tracing instrumentation.
Matt Morehouse via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 17 13:56:23 PDT 2017
morehouse added inline comments.
Comment at: llvm/lib/Fuzzer/FuzzerTracePC.cpp:31
> Why this does not need ATTRIBUTE_INTERFACE?
Not sure why it works without it. Maybe the default build doesn't use
`-fvisibility=hidden`? But seems like a good idea to add.
Comment at: llvm/lib/Fuzzer/FuzzerTracePC.cpp:35
+// Used by -fsanitize-coverage=stack-depth to track stack depth
+thread_local uintptr_t __sanitizer_cov_lowest_stack;
> Should this be __sancov_lowest_stack or even __sancov_stack_depth?
It looks like the current convention is to use `__sancov_*` for variables and `__sanitizer_cov_*` for functions. I'll modify the name here to reflect that. I think `__sancov_lowest_stack` would be the more descriptive choice since the "lowest stack" gets smaller as the "max stack depth" gets larger.
More information about the cfe-commits