[PATCH] D36822: [clang-tidy] Ignore statements inside a template instantiation.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 17 07:01:02 PDT 2017


alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.

LG with a nit.



================
Comment at: test/clang-tidy/modernize-make-unique.cpp:459
+  std::unique_ptr<T> t2 = std::unique_ptr<T>(new T);
+  // CHECK-MESSAGE-NOT: warning:
+  t2.reset(new T);
----------------
The check_clang_tidy script specifies `-implicit-check-not='{{warning:|error:}}'`, so verifying the lack of messages is not necessary (there's no such thing for fixes, since they verify the end state, not the changes; but the lack of messages implies the lack of fixes).


https://reviews.llvm.org/D36822





More information about the cfe-commits mailing list