[PATCH] D36786: [clang-tidy] Don't generate fixes for initializer_list constructor in make_unique check.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 17 02:50:40 PDT 2017

alexfh accepted this revision.
alexfh added a comment.

Still LG with one comment.

Comment at: clang-tidy/modernize/MakeSmartPtrCheck.h:60
-  void replaceNew(DiagnosticBuilder &Diag, const CXXNewExpr *New,
+  /// Returns whether the fixes for replacing CXXNewExpr are generated.
+  bool replaceNew(DiagnosticBuilder &Diag, const CXXNewExpr *New,
I'd suggest using a less ambiguous phrase: instead of "Returns whether X." I write "Returns \c true when X".


More information about the cfe-commits mailing list