[PATCH] D36728: Switch to consumeError(), since this can crash otherwise.

Lang Hames via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 15 17:57:58 PDT 2017

lhames added a comment.

> Is it ok to drop the assertion in that case (and convert it to a comment)? I didn't want to alter too much of this check, since perhaps the original author(s) were more skeptical about this breaking (hence the assertion). Something like:
> // Replacements must not conflict since ranges have been merged.
>  llvm::cantFail(FakeReplaces.add(...));

Yep - cantFail asserts that the result is success, so your proposed change (with the assertion text above the call) is ideal.



More information about the cfe-commits mailing list