[PATCH] D36156: [rename] Introduce symbol occurrences

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 14 08:36:58 PDT 2017

hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.


Comment at: include/clang/Tooling/Refactoring/Rename/SymbolName.h:19
+namespace clang {
+namespace tooling {
arphaman wrote:
> hokein wrote:
> > An off-topic thought: currently we put everything into `clang::tooling`, I think we might need a separate namespace e.g. `clang::tooling::refactoring` in the future? 
> That would be nice, I agree. Don't think it's in scope for this patch though, maybe for https://reviews.llvm.org/D36075?
Sounds good. No need to do it in this patch.



More information about the cfe-commits mailing list